On Fri, 6 Jun 2025 07:12:52 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> I'm confused by this ask. Are you asking me to update 
>> SetEchoCharWordOpsTest.java to include this line:
>> 
>> ` * @bug 6191897 4231444 8354646`
>> 
>> I understand topically these tickets are all related, but I ran 
>> SetEchoCharWordOpsTest in Aqua using master and this branch: I didn't 
>> perceive any difference.
>> 
>> (For context: the git history doesn't really show me if any changes 
>> accompanied SetEchoCharWordOpsTest , but I think it passes because of code 
>> like this: `"PasswordField.focusInputMap", 
>> aquaKeyBindings.getPasswordFieldInputMap()` )
>
> I am asking to add "this bugid" 8354646 in SetEchoCharWordOpsTest.java...
> I see if we double click at beginning and/or at the end it will identify 
> "One" and "Three" separately which is not desirable and it will fail the test 
> checkpoint "if you are able to move the caret word-by-word press Fail" as 
> caret can be placed in between those words before the fix..

Hmm. Sorry; I feel like I'm still not quite understanding the ask. Is this what 
you're asking for? 
https://github.com/openjdk/jdk/pull/25443/commits/39d19f2772cd980f0ee8b812de1b748de858ef56

IMO this feels weird:
A. We'd also need to update the instructions in that test, yes?
B. If we want that test to cover 8354646, then we can delete 
PasswordSelectionWordTest from this PR, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2131671179

Reply via email to