On Fri, 6 Jun 2025 10:07:06 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Jeremy Wood has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8354646: change Error to RuntimeException >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/25443#discussion_r2131681790 >> - 8354646: removing catching RuntimeException >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/25443#discussion_r2131680454 > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line > 654: > >> 652: // Create the action map for Password Field. This map >> provides >> 653: // same actions for double mouse click and >> 654: // and for triple mouse click (see bugs 4231444, 8354646). > > Replace “create” with ”edit”? This is updated > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line > 662: > >> 660: map.put(DefaultEditorKit.selectWordAction, a); >> 661: } >> 662: } > > I think we should still remove `selectWordAction` even if `selectLineAction` > doesn't exist. OK, this is updated > test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java > line 76: > >> 74: "because the JPasswordField UI was " + >> field.getUI()); >> 75: return; >> 76: } > > I'd say that this is unexpected, and it's better to throw an exception and > fail the test. If not fail the test, then throw `jtreg.SkippedException` to > indicate the test doesn't run. OK, now we throw a RuntimeException to fail the test ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2132955551 PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2132955569 PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2132955895
