On Fri, 6 Jun 2025 21:50:44 GMT, Jeremy Wood <d...@openjdk.org> wrote:
>> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI . The same solution was copied and pasted into the >> SynthPasswordFieldUI . But the AquaTextPasswordFieldUI does NOT extend >> either class with the solution. >> >> So the problem is partially about multiple inheritance. >> >> My first response at solving the problem is just to move the existing >> solution to the parent BasicTextUI class and use an `instanceof` to make >> sure it is only applied to JPasswordFields. This should benefit all the >> PasswordFieldUI's (that I know about). >> >> There may be many different philosophies/recommendations on how to resolve >> this; I'm open to suggestions. > > Jeremy Wood has updated the pull request incrementally with five additional > commits since the last revision: > > - 8354646: add missing import > - 8354646: fixing compiler error typo > - 8354646: fail test with exception for unexpected UI > > This is in response to: > https://github.com/openjdk/jdk/pull/25443#discussion_r2131930548 > - 8354646: remove selectWordAction whether or not selectLineAction exists > > This is in response to: > https://github.com/openjdk/jdk/pull/25443#discussion_r2131922909 > - 8354646: change "create" to "edit" in comment > > This is in response to: > https://github.com/openjdk/jdk/pull/25443#discussion_r2131918285 Marked as reviewed by tr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/25443#pullrequestreview-2908975012
