> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
> 
> The core problem here was we could call selectWordAction in the Aqua LAF on a 
> JPasswordField. This problem was already solved in the BasicPasswordFieldUI . 
> The same solution was copied and pasted into the SynthPasswordFieldUI . But 
> the AquaTextPasswordFieldUI does NOT extend either class with the solution.
> 
> So the problem is partially about multiple inheritance.
> 
> My first response at solving the problem is just to move the existing 
> solution to the parent BasicTextUI class and use an `instanceof` to make sure 
> it is only applied to JPasswordFields. This should benefit all the 
> PasswordFieldUI's (that I know about).
> 
> There may be many different philosophies/recommendations on how to resolve 
> this; I'm open to suggestions.

Jeremy Wood has updated the pull request incrementally with one additional 
commit since the last revision:

  8354646: moving test file to new package
  
  This is in response to:
  https://github.com/openjdk/jdk/pull/25443#discussion_r2131872951

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25443/files
  - new: https://git.openjdk.org/jdk/pull/25443/files/7aff3231..19af4e31

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=13
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=12-13

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25443.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25443/head:pull/25443

PR: https://git.openjdk.org/jdk/pull/25443

Reply via email to