On Wed, 8 Oct 2025 03:22:14 GMT, Tejesh R <[email protected]> wrote:

> > @TejeshR13 You can still use this PR to implement adding screenshots, just 
> > change the subject of the PR to associate it with the new bugid.
> 
> New bugid ? You want me to raise another JBS to handle adding screenshots ?

@TejeshR13 Yes, that's what I said.

> Adding a screenshot is not fixing the failure reported in 
> [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915), it's an 
> improvement for the test to have the more information to analyse the failure 
> if it occurs again. **This is why it's a new issue.**

You'll close as *Cannot Reproduce* because no one can reproduce the failure any 
more. (I did run these two tests both off master and with reverted 
[JDK-8305825](https://bugs.openjdk.org/browse/JDK-8305825 "getBounds API 
returns wrong value resulting in multiple Regression Test Failures on Ubuntu 
23.04") as @azvegint suggested; these two tests — `FrameLocation.java` and 
`SizeMinimizedTest.java` — passed in both jobs.)

Then you'll create a new bug to improve `FrameLocation.java` with adding a 
screenshot before disposing of the frame which will provide us with more date 
if the test fails again. Once the new bug id is available, you'll update the 
subject of this PR, and we'll be able to integrate the updated 
`FrameLocation.java` that takes a screenshot when it fails.

I'm not sure if `SizeMinimizedTest.java` will benefit from a screenshot, it 
may… I quickly looked at the test, and `iterationCnt` in 
`SizeMinimizedTest.java` is accessed and modified in a non-thread-safe way, 
which could also lead to test failures. I think this problem needs addressing, 
too… under a separate bugid.

If you like, I can submit both new bugs for you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27366#issuecomment-3381004931

Reply via email to