On Wed, 19 Aug 2026 11:46:40 GMT, Matthias Baesken <[email protected]> wrote:
>> sun/awt/OSInfo.java contains very old Windows versions like Windows 95,98, >> ME. Those can be removed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java > line 1587: > >> 1585: >> 1586: static boolean isOnWindows7() { >> 1587: return OSInfo.getOSType() == OSInfo.OSType.WINDOWS > > btw, we are these days always at least on Windows 7, so why not just return > true in this method ? It is checking the OS type, ie making sure we aren't on Linux, so that's still needed somewhere, but probably isn't needed here. We should be checking that before instantiating the L&F. But pulling on the thread, if we only support win 7 and later, I don't see the need to even have these methods at all. Perhaps the Windows Classic L&F might need something like this in some places, but this check is about the actual OS is, not what L&F variant we want. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r3898873895
