On Mon, 31 Aug 2026 22:20:15 GMT, Phil Race <[email protected]> wrote:
>> sun/awt/OSInfo.java contains very old Windows versions like Windows 95,98, >> ME. Those can be removed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.desktop/share/classes/sun/awt/OSInfo.java line 64: > >> 62: >> 63: static { >> 64: windowsVersionMap.put(WINDOWS_7.toString(), WINDOWS_7); > > If we know about windows 8, 8.1, 10, 11 .. why can't we put these here ? > Because we don't use them in code ? > > So conversely why do we even bother with this map at all ? > If we remove the isOnWindows7() function, nothing needs the WINDOWS_7 > variable. > There might be *some* value in keeping the map, even if it is initially empty > in case we find a reason to have to add an isWindows11() method some day. > > I guess I'm voting for removing WINDOWS_7 and the isVista() / isWindows7() > functions but keeping the map. We could put newer Windows versions here, but I guess it was not done so far, because it wasn't needed so far. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r3901927754
