On Tue, 1 Sep 2026 07:49:49 GMT, Matthias Baesken <[email protected]> wrote:
>> src/java.desktop/share/classes/sun/awt/OSInfo.java line 64:
>>
>>> 62:
>>> 63: static {
>>> 64: windowsVersionMap.put(WINDOWS_7.toString(), WINDOWS_7);
>>
>> If we know about windows 8, 8.1, 10, 11 .. why can't we put these here ?
>> Because we don't use them in code ?
>>
>> So conversely why do we even bother with this map at all ?
>> If we remove the isOnWindows7() function, nothing needs the WINDOWS_7
>> variable.
>> There might be *some* value in keeping the map, even if it is initially
>> empty in case we find a reason to have to add an isWindows11() method some
>> day.
>>
>> I guess I'm voting for removing WINDOWS_7 and the isVista() / isWindows7()
>> functions but keeping the map.
>
> We could put newer Windows versions here, but I guess it was not done so far,
> because it wasn't needed so far.
So can we remove as I suggested ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r3907023424
