On Tue, 1 Sep 2026 14:48:44 GMT, Matthias Baesken <[email protected]> wrote:
>> There are a few more XP/Win200X/Vista references in the D3D coding that >> could be cleaned up . >> I left the win7/Win server 2008R2 - related macros in D3DPipelineManager.h, >> those Windows versions are old too but not as ancient as the others I >> removed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Introduce OS_WINDOWS_7_OR_8 > Also depending on the manifest isn't ideal ! We have no direct control over > that. > Perhaps if we really no longer have a reason to care what the version is then > the whole lot can be ditched. > Or perhaps it should be completely changed ? GetVersionEx is in fact > deprecated. If we do not want to use GetVersionEx , we might consider the version helper functions https://learn.microsoft.com/en-us/windows/win32/sysinfo/version-helper-apis Or we could reuse the java props that are set up here ? https://github.com/openjdk/jdk/blob/879c4a22b6cb13d29da4ebbd048c7b4a578b8ccd/src/java.base/windows/native/libjava/java_props_md.c#L344 ------------- PR Comment: https://git.openjdk.org/jdk/pull/32011#issuecomment-5495995707
