On Wed, 5 Aug 2026 14:26:57 GMT, Matthias Baesken <[email protected]> wrote:
>> There are a few more XP/Win200X/Vista references in the D3D coding that >> could be cleaned up . >> I left the win7/Win server 2008R2 - related macros in D3DPipelineManager.h, >> those Windows versions are old too but not as ancient as the others I >> removed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > handle also Win 10/11/Server 2016 and higher oh ! I just found that comments I made > 3 weeks ago didn't get submitted. pushing submit now. src/java.desktop/windows/native/libawt/java2d/d3d/D3DBadHardware.h line 60: > 58: { 0x1414, 0x008c, NO_VERSION, OS_ALL }, > 59: > 60: // ATI Mobility Radeon X1600, X1400, X1450, X1300, X1350 I'd like to at least leave a couple of comments that look like // AMD / ATI - vendor ID 0x1002, no current hardware block-listed // Nividia - vendor ID 0x10DE, no current hardware block-listed src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp line 392: > 390: J2dRlsTrace(J2D_TRACE_INFO, "[I] OS Version = "); > 391: if (bVersOk) { > 392: if (osvi.dwMajorVersion == 10 && osvi.dwMinorVersion == 0) { I think it would be safer for the future to just do if (osvi.dwMajorVersion >= 10) { src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp line 404: > 402: if (osvi.wProductType == VER_NT_WORKSTATION) { > 403: J2dRlsTrace(J2D_TRACE_INFO, "OS_WINDOWS7 or > newer\n"); > 404: // this detects also Win8 so may be call it OS_WINDOWS_7_OR_8 ? src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp line 408: > 406: } else { > 407: J2dRlsTrace(J2D_TRACE_INFO, "OS_WINSERV_2008R2 > or newer\n"); > 408: // this detects also 2012 (R2) Not really "all newer" so that comment needs adjusting. really 2008R2 -> 2012 .. maybe name it OS_WINSERVER_2008R2_OR_2012 ------------- PR Review: https://git.openjdk.org/jdk/pull/32011#pullrequestreview-4775365442 PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3647069033 PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3897732535 PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3897740043 PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3897752114
