On Mon, 31 Aug 2026 19:37:47 GMT, Phil Race <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> handle also Win 10/11/Server 2016 and higher
>
> src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp line
> 404:
>
>> 402: if (osvi.wProductType == VER_NT_WORKSTATION) {
>> 403: J2dRlsTrace(J2D_TRACE_INFO, "OS_WINDOWS7 or
>> newer\n");
>> 404: // this detects also Win8
>
> so may be call it OS_WINDOWS_7_OR_8 ?
Done !
> src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp line
> 408:
>
>> 406: } else {
>> 407: J2dRlsTrace(J2D_TRACE_INFO, "OS_WINSERV_2008R2
>> or newer\n");
>> 408: // this detects also 2012 (R2)
>
> Not really "all newer" so that comment needs adjusting.
> really 2008R2 -> 2012 .. maybe name it OS_WINSERVER_2008R2_OR_2012
OS_WINSERVER_2008R2_OR_2012 might not be ideal because the check covers too
Windows Server 2012 R2 (Version 6.3).
Maybe use OS_WINSERVER_2008R2_2012_OR_2012R2 ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3905240415
PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3905287496
