On Fri, 2 Oct 2026 16:36:39 GMT, Phil Race <[email protected]> wrote: > This is a "follow-on" to https://git.openjdk.org/jdk/pull/33107 > That fix removed support for un-used edge conditions from the medialib native > code for convolve op. > This removes support for un-used image data types from the medialib native > code for convolve op. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
src/java.desktop/share/native/libmlib_image/mlib_ImageConvMxN.c line 203: > 201: break; > 202: case MLIB_DOUBLE: > 203: ret = mlib_convMxNnw_d64(dst_i, src_i, kernel, m, n, dm, dn, > cmask); Don't we need to return MLIB_FAILURE like in the file [above](https://github.com/openjdk/jdk/pull/33184/changes#diff-62a4472f8faf899987da953d34ef9ff83d7490848eb0293f17680581584136a7R167)? or probably the whole switch should return error by default? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33184#discussion_r4172445200
