On Mon, 5 Oct 2026 17:37:10 GMT, Phil Race <[email protected]> wrote:

>> src/java.desktop/share/native/libmlib_image/mlib_ImageConvMxN.c line 203:
>> 
>>> 201:           break;
>>> 202:         case MLIB_DOUBLE:
>>> 203:           ret = mlib_convMxNnw_d64(dst_i, src_i, kernel, m, n, dm, dn, 
>>> cmask);
>> 
>> Don't we need to return MLIB_FAILURE like in the file 
>> [above](https://github.com/openjdk/jdk/pull/33184/changes#diff-62a4472f8faf899987da953d34ef9ff83d7490848eb0293f17680581584136a7R167)?
>>  or probably the whole switch should return error by default?
>
> You mean change the code in the default block below ?

I've made the update

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33184#discussion_r4187429561

Reply via email to