On Thu, 8 Oct 2026 18:39:34 GMT, Phil Race <[email protected]> wrote: >> src/java.desktop/share/native/libmlib_image/mlib_ImageConvMxN_Fp.c line 83: >> >>> 81: /***************************************************************/ >>> 82: mlib_status mlib_ImageConvMxN_Fp(mlib_image *dst, >>> 83: const mlib_image *src, >> >> Looks like the next function still mentioned in >> https://github.com/openjdk/jdk/blob/054dbd7b6a64c5fd6c3885e5bd1ade03bc80bc9a/src/java.desktop/share/native/libmlib_image/mlib_image_proto.h#L2657 >> ? > > You know .. there's quite a few definitions in there that relate to functions > that aren't anywhere to be found. > At least 'grep' shows them only in that file. > I'll update it to remove the FP convolution ones removed in this PR, and > after this is integrated I'll take a look at how many of the rest are > un-used. That file is 3400 lines long so I do not want to pollute this PR > with all of that which might amount to a lot.
I just spent some time looking at that file. And it is 95% prototypes for non-existent functions. And most of what it does even for what's left is pointless. Nothing is defined using the "__" pre-fixed names and nothing is calling using them, so there's no need to map the names. I will look a bit more to see if it really is something that we actually need. Not for this PR of course, just an observation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33184#discussion_r4224428483
