On Wed, 7 Oct 2026 08:18:11 GMT, Matthias Baesken <[email protected]> wrote:
>> src/java.desktop/share/native/common/awt/debug/debug_trace.h line 65: >> >>> 63: >>> 64: /* each file includes this flag indicating module trace status */ >>> 65: #if defined(__GNUC__) || defined(__clang__) >> >> Just wonder, is this is common pattern we use in jdk? seems most of the time >> we want to check the "__GNUC__" and NOT "__clang__", since __GNUC__ is >> defined by the clang? > > Not sure if there is a common pattern. I can change to GNUC if this is more > common, should I ? Yeah seems we can go for __GNUC__ because we explicitly test !clang if we want only gcc, see here https://github.com/openjdk/jdk/blob/ac70f5612a69c8b6c048206512a323e206b9cb4c/src/jdk.incubator.vector/unix/native/libsleef/upstream/src/common/testerutil.h#L13 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33200#discussion_r4205748794
