On Tue, 6 Oct 2026 22:57:06 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unneeded incldue from awt_LoadLibrary.c > > make/modules/java.desktop/lib/AwtLibraries.gmk line 136: > >> 134: DISABLED_WARNINGS_clang_awt_ImagingLib.c := >> deprecated-non-prototype, \ >> 135: DISABLED_WARNINGS_clang_debug_assert.c := unused-variable, \ >> 136: DISABLED_WARNINGS_clang_debug_mem.c := unused-variable, \ > > possibly we can update the code instead? maybe, but in debug_mem we explicitly state this /* The following line is only here to prevent compiler warnings * on release (non-debug) builds */ static int dummyVariable = 0; So if we **want** unused vars, I cannot do much about it. But not sure how good this dummyVariable 'trick' really is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33200#discussion_r4205767503
