On Fri, 6 Nov 2026 10:40:07 GMT, Jayathirth D V <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use public AWT API in JPEG decoder regression test
>
> src/java.desktop/share/native/libjavajpeg/jpegdecoder.c line 354:
>
>> 352: buflen = (*env)->GetArrayLength(env, src->hInputBuffer);
>> 353: if (offset > buflen) {
>> 354: cinfo->err->error_exit((struct jpeg_common_struct *) cinfo);
>
> I don't think we call error_exit is these scenarios.
> We just return back to the caller(mostly libjpeg code).
Done.
> src/java.desktop/share/native/libjavajpeg/jpegdecoder.c line 373:
>
>> 371: WARNMS(cinfo, JWRN_JPEG_EOF);
>> 372: if (buflen < 2) {
>> 373: cinfo->err->error_exit((struct jpeg_common_struct *) cinfo);
>
> Same here.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33313#discussion_r4492052493
PR Review Comment: https://git.openjdk.org/jdk/pull/33313#discussion_r4492053100