On Tue, 10 Nov 2026 05:19:36 GMT, Jayathirth D V <[email protected]> wrote:
>> @jayathirthrao what did you mean by "these scenarios" ? > > We have a pattern of not directly calling error_exit() from fill/suspend > buffer when we have conditions like ret<=0 or buflen <=0. > We call error_exit() only when we already have an exception or unable to pin > the arrays. > > Initially i thought just returning would be sufficient, but if we just return > libjpeg will keep on trying to fill the suspended buffer and make no progress. > Also enlarging the Java input buffer to hold the extra EOI byte only for this > specific scenario is not a good idea. > > So its better if we just do error_exit() from these places. But if we just call error_exit() directly at this place, we will not have any message for ImageFormatException. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33313#discussion_r4521478260
