On Fri, 6 Nov 2026 20:29:40 GMT, Phil Race <[email protected]> wrote:

>> Timofei Fedotov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Handle invalid JPEG input buffer state in the caller
>
> src/java.desktop/share/native/libjavajpeg/jpegdecoder.c line 653:
> 
>> 651:           do {
>> 652:               sun_jpeg_fill_suspended_buffer(&cinfo);
>> 653:               if (jsrc.invalid_input) {
> 
> So this is in response to Jay's comment, but else where we DO just call 
> error_exit which longjmps to where this same code below exists. We have no 
> other cases where we throw such an exception
> 
> So I'm not sure I understand. Jay ??

We can directly call error_exit() in sun_jpeg_fill_suspended_buffer() but we 
don't have required messaging for all the cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33313#discussion_r4521506121

Reply via email to