I take it you have never worked on a patch for clojure. I have, and I can tell you that it's not the indentation style the issue -- everybody likes his own and it's definitely in the maintainer's rights to chose what indentation style should be used and for contributors to adapt, I don't have a problem with that. I have a problem with the fact that the indentation style is not consistent even between lines of the same method, tabs and spaces are mixed everywhere -- for every non trivial patch I submit I have to spend non trivial amounts of time to reindent my code using spaces or tabs where appropriate to be consistent with the surrounding code and making sure I don't accidentally commit whitespace changes in my patches. It's certainly not the biggest issue (not even close to it) in the contributing process, but it definitely is an issue and it doesn't help making the overall contributing experience a pleasant one, or one would want to repeat.
And the claim that no indentation fix can happen to avoid breaking existing patches in jira is frankly laughable. With the amount of time that usually passes between the writing of a patch and its application to the code base, a lot of them already need to be rebased/rewritten to apply cleanly, often multiple times. On Sat, Jul 18, 2015 at 5:44 PM, Luc Prefontaine <lprefonta...@softaddicts.ca> wrote: > Sure, indentation is what gets the code running on metal :)) > > Not ranting here, just my abs dying from the pain as I laugh :)) > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
