dustymabe added a new comment to an issue you are following: `` > vgoyal > Thinking more about it. I think EXTRA_VOLUME_NAME is more intuitive. Reason > being that this script sets up thin pool volume as well and that's a > container volume too. EXTRA sort of makes it explicit that this volume is on top regular volumes setup by this script.
This script will only set up the thin pool when you are using devicemapper right? So the script would only make a thin pool LV when running for dm and only make a regular LV when running for overlay. So one type of volume gets created. I think if you want them to be different names then they should really be different names: - `OVERLAY_VOLUME_NAME` - `DM_THIN_VOLUME_NAME` - etc. I also don't think it's intuitive to the user that specifying `OVERLAY_VOLUME_NAME` implies `CONTAINER_ROOT_VOLUME=yes` (I know you are proposing that there be no `CONTAINER_ROOT_VOLUME` variable). > dwalsh > DON'T Hard code "dockerisms" into any more tools. Then who is going to modify the docker options in `/etc/sysconfig/docker-storage` to specify devicemapper or overlay? I think if you have to code the tool to be able to do that then having a "default" location for a mountpoint is not that big of a deal. `` To reply, visit the link below or just reply to this email https://pagure.io/atomic-wg/issue/186 _______________________________________________ cloud mailing list -- cloud@lists.fedoraproject.org To unsubscribe send an email to cloud-le...@lists.fedoraproject.org
