On 07/09/2013 05:56 AM, Daniele E. Domenichelli wrote:
> FindQt4, from which the macro is extracted, sets the values to
> XXX_LIBRARY_{DEBUG,RELEASE}-NOTFOUND instead.
>
> I tried to fix these issues, you can find the patches attached.
The changes look good to me, though I have not carefully checked
if the documentation of the module is still accurate after them.
Also please update the commit messages to include the explanations
from your email. Go ahead and push to Git by following the
directions at http://www.cmake.org/Wiki/CMake/Git/Develop
It looks like this functionality was extracted from FindQt4 but
FindQt4 was not refactored to use SelectLibraryConfigurations.
Since then the implementation in FindQt4 has evolved without
porting the changes.
Clinton, is there any reason not to resolve this duplication?
Also, it looks like FindQt4 force-caches the _LIBRARY variable.
Is that necessary instead of just a variable set?
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
