On 10/22/2013 02:51 PM, Pedro Navarro wrote:
>> get_filename_component(TOP "${CMAKE_CURRENT_LIST_FILE}" PATH) could be
>> written
>> as CMAKE_CURRENT_LIST_DIR. I don't remember exactly when it was introduced,
>> but you drive that test with the newly built CMake so this must work. And a
>> newline is missing at the end of that file.
>
> Would that be preferred? I have no issues using it but that's what the other
> tests were using, so I wanted them to be as similar as possible.
Yes. The other tests' code predates CMAKE_CURRENT_LIST_DIR.
I would accept the patch for the new test either way though.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
