Am Dienstag, 22. Oktober 2013, 14:36:36 schrieb Pedro Navarro: > Attached is the new patch with Eike's recommendations.
One more nitpick ;)
+ this->OldRevision = this->GetWorkingRevision();
+ if(this->OldRevision.empty())
+ {
+ this->OldRevision = "0";
+ }
That code comes twice, for the only 2 callers of GetWorkingRevision(). I would
say just modify that method to return "0" in that case.
Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
