Thanks a lot! Glad we could contribute. What's the process for changes? :) Adding support for P4Web in CDash made me realize that maybe we need to change how revisions are reported in Update.xml (file revisions instead of changelists), I'm looking into that right now.
Pedro On Wed, Oct 23, 2013 at 1:49 PM, Brad King <brad.k...@kitware.com> wrote: > On 10/22/2013 06:11 PM, Pedro Navarro wrote: > > Good point :) Here's the new patch. > > Great, thanks! I've applied it: > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c63ecee3 > > with minor tweaks: > > * Updated commit author date to when you sent the email > * Wrote more extensive commit message > * Marked P4_EXECUTABLE as an advanced cache option > * Simplified the cygwin exclusion logic for adding the test > * Quoted the p4d shell command args to support spaces in path > > I also downloaded the p4 and p4d binaries and put them on > the hythloth.kitware dashboard machine so they should run as > part of its Linux64-gnu test tonight. I used them to run the > test locally and it works for me :) > > Great work, > -Brad >
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
