On 09/26/2014 09:52 AM, Brad King wrote: > I've applied the patch and merged to our 'next' branch for > testing: > > CPack: Add support for code signing of bundles on MacOS > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a9b0668
I reverted the topic because several CPackComponents tests fail on OS X when the 'codesign' binary is not available. > + const std::string codesign_path = cmSystemTools::FindProgram("codesign", > + std::vector<std::string>(), false); > + if(codesign_path.empty()) > + { > + cmCPackLogger(cmCPackLog::LOG_ERROR, > + "Cannot locate codesign command" > + << std::endl); > + return 0; > + } > + this->SetOptionIfNotSet("CPACK_COMMAND_CODESIGN", codesign_path.c_str()); It should not be an error for 'codesign' to not be available in the PATH. The user may have set CPACK_COMMAND_CODESIGN to some other location. The error should only occur if no value for CPACK_COMMAND_CODESIGN is available when the tool is actually needed for signing. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers