Maybe it shouldn't even be a CPack thing..... Maybe it should be an install time step so that all CPack generators will contains signed binaries if codesign is used...
D On Mon, Sep 29, 2014 at 9:55 AM, <clin...@elemtech.com> wrote: > > > ________________________________ >> >> It should not be an error for 'codesign' to not be available >> in the PATH. The user may have set CPACK_COMMAND_CODESIGN >> to some other location. The error should only occur if no >> value for CPACK_COMMAND_CODESIGN is available when the tool >> is actually needed for signing. > > > I attached another patch that will fix the broken tests. It will check for > defined CPACK_APPLE_CERT_APP before it will search for 'codesign'. > > Well, the FindProgram line for codesign looks like the line for Rez, > hdiutil, SetFile and so on. I don't know cmake sources enough... but > shouldn't it be the same here? > > > Because it appears to only work with the Bundle generator, can you please > move the documentation from Modules/CPackDMG.cmake to > Modules/CPackBundle.cmake? > Or did you intend to make this feature work for both the DragNDrop and > Bundle generator? > > Thanks, > Clint > > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers