André, Please respond with comments or an updated patch to address Clinton's review comments in order to help this contribution proceed.
On 09/26/2014 10:08 AM, clin...@elemtech.com wrote: > I would suggest the SignPackage function be moved from > cmCPackDragNDropGenerator to cmCPackBundleGenerator because > its implementation is only usable by cmCPackBundleGenerator. > It uses CPACK_BUNDLE_NAME which is only valid in the context > of cmCPackBundleGenerator. On 09/29/2014 09:55 AM, clin...@elemtech.com wrote: > Because it appears to only work with the Bundle generator, can > you please move the documentation from Modules/CPackDMG.cmake > to Modules/CPackBundle.cmake? > Or did you intend to make this feature work for both the > DragNDrop and Bundle generator? On 09/29/2014 02:00 PM, Clinton Stimpson wrote: > I think application signing is generally not a CPack thing, but > there probably isn't much of a choice if the Bundle generator > is used. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
