Alright thanks Brad! I have a similar change that applies the exact same code logic to install(DIRECTORY), but I haven't wrote the test yet. Should I still write a test for it before I send it to you?
-----Original Message----- From: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday, September 23, 2015 3:03 PM To: Robert Goulet <robert.gou...@autodesk.com>; cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination On 09/23/2015 01:47 PM, Robert Goulet wrote: > Updated patch for install(FILES) DESTINATION genex support. Test added as > well. Thanks. I applied it without the test: install: Allow generator expressions in FILES DESTINATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=17aa6fd3 and then added alternative tests: Tests: Cover install(FILES) with a genex DESTINATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=69ab5f55 I was concerned that the original test case depended too much on possibly platform-specific file names and such. I also added a test for a bad genex producing an error message. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
