Yeah I guess it could look something like this (attachment). However I just realized that if I don't also get install(DIRECTORY) in 3.4 then this is not worth rushing it, since as you mention I would also need to write proper test cases.
Just let me know when I can start looking at this again (after your refactoring is done) and I'll try to do the proper work to make it work with all install types destinations (files, directory and export). -----Original Message----- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Stephen Kelly Sent: Tuesday, September 22, 2015 4:53 PM To: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination Robert Goulet wrote: > Ok then perhaps the refactoring can wait but we'd still like to get > install(FILES) destination genex support in 3.4 if possible, and genex > evaluation requires the cmMakefile. How should we proceed then? cmLocalGenerator has a GetMakefile method (currently). Don't you just need to use this->LocalGenerator->GetMakefile() in cmInstallFilesGenerator? Whether Brad would still accept a patch like that for 3.4 I don't know, but I think it should be a relatively simple implementation? However, there may need to be more tests for the new functionality and error cases etc. Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
install-files-dest-genex.patch
Description: install-files-dest-genex.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
