On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly <steve...@gmail.com> wrote: > Tobias Hunger wrote: >> Forcing messages into one consistent format will be a pain, agreed, but >> continuing to add messages in whatever form the developer likes at the >> time of writing the code is even worse. CMake has a lot of different error >> message styles! > > This is something my branch addresses in part, which is why I drew attention > to it in the context of the daemon. > >> If you were to unify on e.g. >> >> CMake Error at FILE:LINE (OPTIONAL_EXTRA_INFO): >> MULTILINE_MESSAGE_WITH_INDENT_ENDING_IN_TWO_NEWLINES >> >> then you will probably hit existing code paths in IDEs. > > I don't think that's possible for all messages (not all messages have file > or line information). > > However, that's not a problem when messages are delivered through the > daemon, so I suggest that > > https://github.com/steveire/cmake/tree/extract-cmMessenger > > and the daemon itself are good places to direct your attention to improve > this situation.
I have reviewed the branch and wrote some inline comments on github. Overall, I confirm this is the right approach. So, "approval" from my side. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
