On 06/10/2016 10:07 PM, Daniel Pfeifer wrote: > On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly <steve...@gmail.com> wrote: >> However, that's not a problem when messages are delivered through the >> daemon, so I suggest that >> >> https://github.com/steveire/cmake/tree/extract-cmMessenger >> >> and the daemon itself are good places to direct your attention to improve >> this situation. > I have reviewed the branch and wrote some inline comments on github. > Overall, I confirm this is the right approach. So, "approval" from my side.
Thanks for your thorough review! I think I've fixed the errors I introduced while rebasing now. I'm not completely certain that the gymnastics I do with the cmListFileBacktrace in the parser in the early commits in the branch are correct or appropriate. Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
