On 06/11/2016 08:14 AM, Stephen Kelly wrote: > Thanks for your thorough review! I think I've fixed the errors I > introduced while rebasing now. > > I'm not completely certain that the gymnastics I do with the > cmListFileBacktrace in the parser in the early commits in the branch are > correct or appropriate.
The role of `.Pop()` on `lfbt = this->Backtrace.Pop()` is not clear. I was not able to produce a RunCMake.Syntax test failure by removing it. The clean-up-Parser topic currently strips the backtrace lines and some other context from some expected test output even though the lines still appear, such as in Tests/RunCMake/Syntax/UnterminatedBracket0-stderr.txt and I think a few others. Please restore the context lines where possible. Overall I like the cleanup though. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
