Charles Duffy wrote:
> We use runit, a daemontools-alike init process which doesn't like 
> processes to daemonize. cobblerd doesn't play well in this 
> environment; the attached patch is one proposed fix, and also adds 
> -h/--help and some customization to logging behavior to cobblerd. 
> (runit and daemontools also prefer that processes log to 
> stdout/stderr; allowing an arbitrary filename means that /dev/stdout 
> is an option).
>
> This hasn't been well-tested -- and isn't slated for internal QA for a 
> significant while -- but it seemed sensible to submit what I have 
> rather than sitting on it interminably. Feedback welcome.
> ------------------------------------------------------------------------
>
> _______________________________________________
> cobbler mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/cobbler

Looks reasonable and I very much like the idea ...

One small problem -- if daemonize is the default behavior, we don't need 
a redundant --daemonize flag, do we?   You could just change the action 
to the Optparse call to "store_false", so self.options.daemonize would 
be set correctly.   That way we can be sure it's not None and we don't 
need to specify either --no-daemonize or --daemonize.

If you can add that, I can do some testing on it.

Thanks!

--Michael


_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to