Michael DeHaan wrote:
> One small problem -- if daemonize is the default behavior, we don't need 
> a redundant --daemonize flag, do we?   You could just change the action 
> to the Optparse call to "store_false", so self.options.daemonize would 
> be set correctly.   That way we can be sure it's not None and we don't 
> need to specify either --no-daemonize or --daemonize.

It's already guaranteed not None, because of this line:

     op.set_defaults(daemonize=True, log_level=None)

The redundant --daemonize flag is there to provide a mechanism for init 
scripts to survive changes in defaults; if you don't like the smell, 
there's certainly no reason to keep it.

_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to