Michael DeHaan wrote: > Charles Duffy wrote: > >> Michael DeHaan wrote: >> >> >>> One small problem -- if daemonize is the default behavior, we don't need >>> a redundant --daemonize flag, do we? You could just change the action >>> to the Optparse call to "store_false", so self.options.daemonize would >>> be set correctly. That way we can be sure it's not None and we don't >>> need to specify either --no-daemonize or --daemonize. >>> >>> >> It's already guaranteed not None, because of this line: >> >> op.set_defaults(daemonize=True, log_level=None) >> >> The redundant --daemonize flag is there to provide a mechanism for init >> scripts to survive changes in defaults; if you don't like the smell, >> there's certainly no reason to keep it. >> >> _______________________________________________ >> cobbler mailing list >> [email protected] >> https://fedorahosted.org/mailman/listinfo/cobbler >> >> > Fair enough ... I'll look at this shortly. > > FWIW, daemonize should be the default for the forseeable future -- > unless Fedora adopts a very radically different init system, in which > case we could just tweak the init scripts. > > --Michael > > > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
This has lots of errors for me when running "make test" trying to start the daemon. I tried to fix a few simple things thinking they were Python version related (missing --log-file option, etc), but there were also some problems with methods being fed the wrong number of arguments. Please correct these, verify "make test" works, try the daemon/non-daemon modes both, and submit a new patch if you'd like this added. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
