On Sat, 22 Jun 2019, Markus Elfring wrote:
> > It could be helpful to replace the last line by:
> >
> > (
> > e3 = <+...var...+>
>
> Can this SmPL specification make sense as another when constraint?
No. When is about the code between the code that matches what is before
or after. If you put when, you will get a false positives for var = var +
1.
>
>
> > |
> > * var = e3
> > )
> >
> > In that case, it would also be beneficial to remove the *
>
> I find the asterisk required here
Yu can do whatever you want, but you will get lotsof false positives if
you keep it. If you really want a star on the declaration then you need
to make two rules. The first that finds the positions of the places that
match and the second that only puts a * when there is both a matched
declaration and a matched reinitialization. But I wold imagine that from
the reinitialization, it would be easy to find the declaration, so it
doesn't seem worth further complicating the rule.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
