Anton-Shutik commented on code in PR #29044:
URL: https://github.com/apache/airflow/pull/29044#discussion_r1081523720
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -169,6 +169,33 @@ def get_uri(self) -> str:
conn.schema = self.__schema or conn.schema
return conn.get_uri()
+ def resolve_rds_cname(self, hostname):
Review Comment:
Agree that it is not the best place for that, just wanted to not duplicate
the code for PG and MySql hooks. Also, that code path is optional and won't be
triggered until we provide `{"resolve_rds_cname": true}` in extra config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
