potiuk commented on code in PR #29044:
URL: https://github.com/apache/airflow/pull/29044#discussion_r1082740254
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -169,6 +169,33 @@ def get_uri(self) -> str:
conn.schema = self.__schema or conn.schema
return conn.get_uri()
+ def resolve_rds_cname(self, hostname):
Review Comment:
Why: because when/if we split providers, having an AWS-specific code in
common code is no-go. All the AWS code should be in the provider. If we leave
the code in common code that means that the AWS service is privilledged and can
do more than other services that have their providers implemented in the
community or outside. It would mean that you cannot implement something similar
for GCP, Azure or Digital Ocean without modifying Airlfow core or common.sql.
And this means that anyone writing their own provider is impaired and
limited. This is not what we promised when we say people "it does not matter
whether you implement your own provider, or you are part of the core".
We are not yet there - of course - but I hope we will one day. And adding
more things to unentangle when we do is not an option for me,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
