potiuk commented on code in PR #29044:
URL: https://github.com/apache/airflow/pull/29044#discussion_r1082731538
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -169,6 +169,33 @@ def get_uri(self) -> str:
conn.schema = self.__schema or conn.schema
return conn.get_uri()
+ def resolve_rds_cname(self, hostname):
Review Comment:
Nope. That's not enough. I do not want the AWS code to be in non-AWS
provider (even though we have it now in places).
We have an AWS provider - all code specific to AWS should be there, if/when
we split providers out of Airlfow core, I do not want any external service code
in "apache-airlfow" package.
The requirement is simple none of AWS-specific code should be in
apache/airlfow/providers/common/sql or apache/airflow. All the AWS-specific
code should be in apache/airflow/providers/aws/
That's very simple and straighforward expectation. Exactly how this should
be done and how the code is to be injected from one package to the other (via
callbacks, hooks, etc. ) - I am open to any proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
