ephraimbuddy commented on code in PR #29832:
URL: https://github.com/apache/airflow/pull/29832#discussion_r1124058690
##########
airflow/utils/task_group.py:
##########
@@ -245,6 +245,8 @@ def add(self, task: DAGNode) -> None:
elif SetupTeardownContext.is_teardown:
if isinstance(task, AbstractOperator):
setattr(task, "_is_teardown", True)
+ if getattr(SetupTeardownContext, "on_failure_fail_dagrun",
False):
+ setattr(task, "_on_failure_fail_dagrun", True)
Review Comment:
If that's the case, should we still have @setup/@teardown decorator because
it seems to me that users would now be able to set their tasks as
setup/teardown when defining it in the task? e.g:
```python
BashOperator(task_id='mytask', is_setup=True, bash_command="echo 1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
