jedcunningham commented on code in PR #29832:
URL: https://github.com/apache/airflow/pull/29832#discussion_r1138755790
##########
airflow/utils/setup_teardown.py:
##########
@@ -43,15 +44,17 @@ def setup(cls):
@classmethod
@contextmanager
- def teardown(cls):
+ def teardown(cls, on_failure_fail_dagrun=False):
Review Comment:
```suggestion
def teardown(cls, *, on_failure_fail_dagrun=False):
```
##########
airflow/models/baseoperator.py:
##########
@@ -929,7 +930,8 @@ def as_setup(cls, *args, **kwargs):
def as_teardown(cls, *args, **kwargs):
from airflow.utils.setup_teardown import SetupTeardownContext
- with SetupTeardownContext.teardown():
+ on_failure_fail_dagrun = kwargs.pop("on_failure_fail_dagrun", False)
+ with SetupTeardownContext.teardown(on_failure_fail_dagrun):
Review Comment:
```suggestion
with
SetupTeardownContext.teardown(on_failure_fail_dagrun=on_failure_fail_dagrun):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
