norm commented on code in PR #29832:
URL: https://github.com/apache/airflow/pull/29832#discussion_r1124360657
##########
airflow/utils/task_group.py:
##########
@@ -245,6 +245,8 @@ def add(self, task: DAGNode) -> None:
elif SetupTeardownContext.is_teardown:
if isinstance(task, AbstractOperator):
setattr(task, "_is_teardown", True)
+ if getattr(SetupTeardownContext, "on_failure_fail_dagrun",
False):
+ setattr(task, "_on_failure_fail_dagrun", True)
Review Comment:
Setting `on_failure_fail_dagrun` as a default in the BaseOperator seems
weird. At least to me. Like, it should only apply to a teardown task as that's
how it's described. And the default of `False` in this case is opposite to the
usual behaviour of an operator of failing the run, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
