potiuk commented on PR #30259: URL: https://github.com/apache/airflow/pull/30259#issuecomment-1497012733
> Airflow best practices on Variables: https://airflow.apache.org/docs/apache-airflow/stable/best-practices.html#airflow-variables. Didn't see that mentioned in the discussions and thought it would be useful We discussed it extensively in https://lists.apache.org/thread/ppbb87tohos9zs1yv6pf8b2zyq66dmdk :). I am in favour of merging it as experimental feature, and adding a description to best practices that this is an experimental feature that can improve performance of handling the variables retrieval at parsing time - possibly even explain tha this is transitional solution until the best practices are followed (disabled by default). I would treat it very much the same way as any other optimisation "knob" we have. I think if the user is good with the performance they have while using the variables, we should not make it harder for them (especially that we know that many of our users already use that pattern). This should however mention, that the execution side is not impacted and that they might still need to apply best practices if they see too much of a database overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
