Taragolis commented on code in PR #33881:
URL: https://github.com/apache/airflow/pull/33881#discussion_r1308790721


##########
airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -24,7 +24,6 @@
 
 if TYPE_CHECKING:
     from mypy_boto3_appflow.client import AppflowClient
-    from mypy_boto3_appflow.type_defs import TaskOutputTypeDef, TaskTypeDef
 

Review Comment:
   My point just keep annotations only for `boto3.client` in this case it is 
pretty safe to survive after changes, AFAIK `mypy-boto3-{service-name}` build 
in top of `botocore` JSON data definition, changes in methods are rare, rather 
than in methods types.
   
   [I have an idea in the 
past](https://github.com/apache/airflow/discussions/28560) to make all AWS 
Hooks based on Generic, maybe it is even better than I decide do not 
implemented it. Also `mypy-boto3-{service-name}` pretty heavy, I don't remember 
exact numbers but I guess full size would be 100-200 MB



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to