Taragolis commented on code in PR #33881:
URL: https://github.com/apache/airflow/pull/33881#discussion_r1308834912


##########
airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -24,7 +24,6 @@
 
 if TYPE_CHECKING:
     from mypy_boto3_appflow.client import AppflowClient
-    from mypy_boto3_appflow.type_defs import TaskOutputTypeDef, TaskTypeDef
 

Review Comment:
   > So you think it's just safe to remove mypy ones? can we do it without 
loosing anyting ? Can You do it :D ?
   
   I would be better keep what we have now, and maybe move 
`mypy-boto3-{service-name}` packages into provider extra block, I could have a 
look what we should do for it.
   
   @o-nikolas Do you think is it even possible to implements 
https://github.com/apache/airflow/issues/11297 or maybe we should decide that 
in `won't fixed`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to