potiuk commented on code in PR #33881:
URL: https://github.com/apache/airflow/pull/33881#discussion_r1309685611
##########
airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -24,7 +24,6 @@
if TYPE_CHECKING:
from mypy_boto3_appflow.client import AppflowClient
- from mypy_boto3_appflow.type_defs import TaskOutputTypeDef, TaskTypeDef
Review Comment:
> I would be better keep what we have now, and maybe move
mypy-boto3-{service-name} packages into provider extra block, I could have a
look what we should do for it.
We could simply move them to `devel-only` extra. This is where we keep all
things we want to have in CI image, but we do not want to make them direct
dependencies of the packages. It's a bit disorganised and As I noticed
yesterday we had forgottten "qubole" in there but let me just do it really
quickly to split it into several dicts "per-provider" so that it will at least
be organized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
