potiuk commented on code in PR #34004:
URL: https://github.com/apache/airflow/pull/34004#discussion_r1313073041


##########
dev/breeze/src/airflow_breeze/params/doc_build_params.py:
##########
@@ -42,6 +55,9 @@ def args_doc_builder(self) -> list[str]:
             doc_args.append("--one-pass-only")
         if AIRFLOW_BRANCH != "main":
             doc_args.append("--disable-provider-checks")
+        # if short_version is set, the self.package_filter is preprocessed

Review Comment:
   I think it would be better to use the `argument` instead of 
`--short-version`. And you already have this one:
   
   ```
   argument_packages_plus_all_providers = click.argument(
       "packages_plus_all_providers",
       nargs=-1,
       required=False,
       type=BetterChoice(["all-providers"] + 
get_available_documentation_packages(short_version=True)),
   )
   ```
   
   See where it us used.
   
   The advantage of using argument over option is tha tyou can use it without 
anything like this:
   
   ```
   breeze build.docs cncf.kubernetes apache-airflow sftp
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to