potiuk commented on code in PR #34004:
URL: https://github.com/apache/airflow/pull/34004#discussion_r1314233982


##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -357,6 +358,7 @@ def start_airflow(
 @main.command(name="build-docs")
 @click.option("-d", "--docs-only", help="Only build documentation.", 
is_flag=True)
 @click.option("-s", "--spellcheck-only", help="Only run spell checking.", 
is_flag=True)
+@argument_packages_plus_all_providers
 @option_builder
 @click.option(
     "--package-filter",

Review Comment:
   I think we can change the type of the `--package-filter` to be just `string` 
instead of the list of package filter values available and instead explain in 
the help that you can use `apache-airflow-providers-<provider>` or `shorthand 
package id` or `glob pattern matching the full package name`.  There is  no 
need any more to do auto-complete for those or to display available values - 
since we have shorthand names which are auto-complete'able and we have the list 
of those in `--help`` output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to