Taragolis commented on code in PR #34807:
URL: https://github.com/apache/airflow/pull/34807#discussion_r1355837567


##########
airflow/providers/amazon/aws/waiters/databrew.json:
##########
@@ -0,0 +1,54 @@
+{
+    "version": 2,
+    "waiters": {
+        "job_complete": {
+            "operation": "DescribeJobRun",
+            "delay": 30,
+            "maxAttempts": 60,
+            "acceptors": [
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "STOPPED",
+                    "state": "success"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "SUCCEEDED",
+                    "state": "success"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "FAILED",
+                    "state": "success"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "TIMEOUT",
+                    "state": "success"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "Starting",
+                    "state": "retry"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "STOPPING",
+                    "state": "retry"
+                },
+                {
+                    "matcher": "path",
+                    "argument": "State",
+                    "expected": "RUNNING",
+                    "state": "retry"
+                }

Review Comment:
   ```suggestion
                   }
   ```
   
   There are only two available options of state in botocore waiter `success` 
or `failure`, if you need to keep waiting (e.g. intermediate states) then you 
do not need add anything for the matcher
   
   
https://github.com/boto/botocore/blob/f0ff061aebd9ef15a66f87b675789275e373da43/botocore/waiter.py#L366-L371



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to